-
Notifications
You must be signed in to change notification settings - Fork 508
[modsecurity] Generate processor tags and normalize error handler #15563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[modsecurity] Generate processor tags and normalize error handler #15563
Conversation
|
/test |
- Generate tags for processors missing tags - Normalize the pipeline error handler
908cfcf to
5b47582
Compare
💚 Build Succeeded
History
|
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
| patterns: | ||
| - "%{NOTSPACE:http.request.method} %{URIPATHPARAM:url.original}(?: HTTP/%{NUMBER:http.version})" | ||
| - rename: | ||
| tag: rename_json_transaction_request_headers_host_to_json_transaction_request_headers_Host_50a00924 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious.. Hope there is no limitation on the tag character length?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question... I don't think there is? Not aware of anything in elasticsearch itself (aside from maybe the default limit we put on fields, I can't recall what it was but I think it's 1024 or higher). I don't think BigQuery will impose any limits either. Data types should be variable length, and don't think we impose limits there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haetamoudi, are you aware of limits in BigQuery or other places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fine. Here is a valid tag name that is already present in stats tables in bigquery
Line 642 in 2b57770
| tag: grok_for_message_id_0203-0017_0203-0018_0203-0019_0203-0009_0203-000A_0203-000B_0203-000D_0203-000E_0203-0011_0203-0012_0203-0015_0203-0020_0203-0026_0203-0029_0203-002A_021A-0007_021A-0008_021A-0009_021A-000B_021A-000C_021A-000D_021A-0014 |
|
Package modsecurity - 1.21.2 containing this change is available at https://epr.elastic.co/package/modsecurity/1.21.2/ |
Proposed commit message
Checklist
changelog.ymlfile.- [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices